Fix #162: allow empty topic list in messages #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
The fix should actually not be required. In the the |
| @@ -159,6 +159,9 @@ var inputPostFormatter = function(post) { | |||
| post.priority = utils.fromDecimal(post.priority); | |||
|
|
|||
| // fallback | |||
| if (post.topics == undefined) { | |||
| post.topics = [] | |||
| } | |||
| if (!utils.isArray(post.topics)) { | |||
There was a problem hiding this comment.
Can you remove this? As the line below already takes care of creating and array if non is given.
There was a problem hiding this comment.
If I remove this check, then the sample code crashes with
TypeError: Cannot read property 'length' of undefined
at toHexNative (/usr/lib/node_modules/web3/lib/utils/utils.js:121:27)
at Object.fromAscii (/usr/lib/node_modules/web3/lib/utils/utils.js:139:15)
at /usr/lib/node_modules/web3/lib/web3/formatters.js:168:22
at Array.map (native)
at inputPostFormatter (/usr/lib/node_modules/web3/lib/web3/formatters.js:167:31)
at /usr/lib/node_modules/web3/lib/web3/method.js:86:28
at Array.map (native)
at Method.formatInput (/usr/lib/node_modules/web3/lib/web3/method.js:85:32)
at Method.toPayload (/usr/lib/node_modules/web3/lib/web3/method.js:130:23)
at Method.send (/usr/lib/node_modules/web3/lib/web3/method.js:148:24)
There was a problem hiding this comment.
this is the contents of post.topics: [ undefined ] if I don't specify any in my code.
There was a problem hiding this comment.
True, can you refactor the part like this:
// fallback
if (!utils.isArray(post.topics)) {
post.topics = post.topics ? [post.topics] : [];
}
// format the following options
post.topics = post.topics.map(function(topic){
return utils.fromAscii(topic);
});
frozeman
added a commit
that referenced
this pull request
Apr 17, 2015
Fix #162: allow empty topic list in messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.