events refactor

[debris]

changes

• event.js && contract.js refactored
• new file function.js
• indexed params are now null if not specified

[coveralls]

Coverage increased (+0.86%) to 94.95% when pulling eeb0bc0 on events_refactor into cdf02ec on develop.

[frozeman]

I would probably call this abi instead of json for clarity.

[frozeman]

Please see my answers on you comments.

Additionally we need to fix the events output to match the docs in event.js line 120 from:

    var result = {
        event: this.displayName(),
        number: data.number,
        hash: data.hash,
        args: {}
    };

to:

    var result = {
        event: this.displayName(),
        args: {},
        logIndex: data.logIndex,
        transactionIndex: data.transactionIndex,
        transactionHash: data.transactionHash,
        address: data.address,
        blockHash: data.blockHash,
        blockNumber: data.blockNumber
    };

And probably run data first through the log output formatter.

[debris]

fields are fixed in latest pr

[debris]

now I will do

myContract.myFunction.sendTransaction({value: 20});
// and
myContract.myFunction.call();

[debris]

once this pr is merged we will upgrade version to 0.3.0

[coveralls]

Coverage increased (+0.25%) to 94.34% when pulling e910736 on events_refactor into 42e759e on develop.

[coveralls]

Coverage increased (+0.63%) to 94.73% when pulling 1ac1ef9 on events_refactor into f37057e on develop.

[coveralls]

Coverage increased (+1.26%) to 95.36% when pulling 9f7d6a9 on events_refactor into f37057e on develop.

[coveralls]

Coverage increased (+1.27%) to 95.37% when pulling 3d3db61 on events_refactor into f37057e on develop.

[frozeman]

The contract tests are still the same showing e.g.:

contract.call({from: address, gas: 50000}).balance(address);

This shouldn't work anymore, or do we have backwards compatibility?

Can we add contract tests which also use the ..myMethod.sendTransaction() and ..myMethod.call() syntax?

[frozeman]

events.js:120 is still the same, and has not the necessary properties.

EDIT: i take it back, it didn't pull correctly for me. But i think its better to use the proper log output formatter before, than doing it manually in the event.js again.

As it is we would need to update two places when we change the log output

[debris]

Can we add contract tests which also use the ..myMethod.sendTransaction() and ..myMethod.call() syntax?

done

[coveralls]

Coverage increased (+1.27%) to 95.37% when pulling 960e9c9 on events_refactor into f37057e on develop.