Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #2435

Merged
merged 9 commits into from
Mar 1, 2019
Merged

Testing #2435

merged 9 commits into from
Mar 1, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 1, 2019

Description

This PR contains fixes from testing the code base and preparing the release of it.

Type of change

  • Fixes
  • Enhancements

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug Enhancement Includes improvements or optimizations In Progress Currently being worked on labels Mar 1, 2019
@nivida nivida removed the In Progress Currently being worked on label Mar 1, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.568% when pulling 554b0e8 on fixes/testing into ed6af48 on 1.0.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.568% when pulling 554b0e8 on fixes/testing into ed6af48 on 1.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.568% when pulling 554b0e8 on fixes/testing into ed6af48 on 1.0.

@nivida
Copy link
Contributor Author

nivida commented Mar 1, 2019

Dtslint has still problems with resolving of some dependencies with nodejs v9 on travis. The travis build pipeline is running locally with nodejs v9. That's why I've merged this PR with failed checks.

@nivida nivida merged commit d304f67 into 1.0 Mar 1, 2019
@nivida nivida deleted the fixes/testing branch March 1, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants