Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProviderResolver is now minification save #2521

Merged
merged 3 commits into from
Mar 18, 2019
Merged

ProviderResolver is now minification save #2521

merged 3 commits into from
Mar 18, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 18, 2019 •
edited

Description

Fixes #2484

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Mar 18, 2019
@nivida nivida removed the In Progress Currently being worked on label Mar 18, 2019
@nivida nivida mentioned this pull request Mar 18, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 98.504% when pulling dc29f10 on issue/2484 into 4bd1410 on 1.0.

@coveralls
Copy link

coveralls commented Mar 18, 2019 •
edited

Coverage Status

Coverage decreased (-0.0003%) to 98.506% when pulling e4af4b5 on issue/2484 into 5cdf1af on 1.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 98.504% when pulling dc29f10 on issue/2484 into 4bd1410 on 1.0.

@nivida nivida merged commit 61b8ee8 into 1.0 Mar 18, 2019
@nivida nivida deleted the issue/2484 branch March 18, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProviderResolver is not minification safe
2 participants
@nivida @coveralls