Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for callbacks fixed. #2740

Merged
merged 5 commits into from
Apr 26, 2019
Merged

Error handling for callbacks fixed. #2740

merged 5 commits into from
Apr 26, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Apr 26, 2019

Description

Fixes the error handling for the usage of a callback.

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added the Bug Addressing a bug label Apr 26, 2019
@nivida nivida added the In Progress Currently being worked on label Apr 26, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 95.924% when pulling 2b43929 on enhancement/error-handling-call-method into 54c6650 on 1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 95.924% when pulling 2b43929 on enhancement/error-handling-call-method into 54c6650 on 1.0.

@nivida nivida removed the In Progress Currently being worked on label Apr 26, 2019
@nivida nivida merged commit 07af2e0 into 1.0 Apr 26, 2019
@nivida nivida deleted the enhancement/error-handling-call-method branch April 26, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nivida @coveralls