Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @types/node to dev dependencies #3453

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Move @types/node to dev dependencies #3453

merged 2 commits into from
Apr 6, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Apr 2, 2020

Description

#3412 redux (This is being re-opened on a local branch because the original PR was made directly from the 1.x branch of a fork and needed some maintainer edits -cg )

moving @types/node to a devDependency. It isn't needed at runtime, and if a library user is is targeting browser this dependency will give them incorrect type hints.

Fixes #2965

and re confirmation request of #3337

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • [] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • [] I have updated the CHANGELOG.md file in the root folder.
  • [] I have tested my code on the live network.

@cgewecke
Copy link
Collaborator Author

cgewecke commented Apr 2, 2020

(From my previous review...)

"LGTM - the types tests import net from NodeJS and there's no other reference. "

@cgewecke cgewecke added 1.x 1.0 related issues dependencies Review Needed Maintainer(s) need to review Types Incorrect or missing types labels Apr 2, 2020
@coveralls
Copy link

coveralls commented Apr 2, 2020

Coverage Status

Coverage remained the same at 86.048% when pulling cf8db2d on cokia/node-types into d063437 on 1.x.

@cgewecke
Copy link
Collaborator Author

cgewecke commented Apr 3, 2020

@holgerd77 You reviewed this as #3412 - have reopened it here addressing some concerns raised
about the scope of the package-lock changes.

Copy link
Collaborator

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit ad00335 into 1.x Apr 6, 2020
@holgerd77 holgerd77 deleted the cokia/node-types branch April 6, 2020 19:52
@cokia
Copy link
Contributor

cokia commented Apr 7, 2020

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move types to devDependency.
4 participants