Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade devDeps to resolve security warnings #3464

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Upgrade devDeps to resolve security warnings #3464

merged 1 commit into from
Apr 10, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Apr 10, 2020

Description

This PR upgrades devDeps dtslint and definitelytyped-header-parser to resolve some security warnings with older versions of minimist.

The PR also changes the behavior of the dtslint script to remove the option --onlyTestTsNext since TypeScript 3.9 beta was throwing build errors. It pins the typescript dep in the root package.json to TypeScript 3.8.3.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I have executed npm run test:cov and my test cases do cover all lines and branches of the added code.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added the Review Needed Maintainer(s) need to review label Apr 10, 2020
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! LGTM.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.596% when pulling e0a8c1d on upgradeDtslintDep into bd9cf48 on 1.x.

@ryanio ryanio merged commit 3684fc3 into 1.x Apr 10, 2020
@holgerd77 holgerd77 deleted the upgradeDtslintDep branch April 14, 2020 15:00
@cgewecke cgewecke added this to Done in v1.2.8 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed Maintainer(s) need to review
Projects
No open projects
v1.2.8
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants