Solve unhandled rejection if the error event handler of a transaction throws #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabmontes
force-pushed
the
issue/3708
branch
from
a1975ab
to
ead64c5
Compare
spacesailor24
previously approved these changes
Sep 8, 2020
There was a problem hiding this comment.
I've tested the replication steps mentioned in #3708, and these changes seems to allow the actual Web3 error to be returned to the user (instead of the unhandled promise rejection error)
GregTheGreek
previously approved these changes
Sep 25, 2020
|
@gabmontes do you mind updating the changelog |
|
@gabmontes any update please |
gabmontes
dismissed stale reviews from GregTheGreek and spacesailor24
via
042482f
|
@GregTheGreek I just rebased the commits on top of ´1.x´ to eliminate the merge conflict. Thanks for pinging me again. Just missed your original message. |
|
Thanks for the quick turn around :) |
GregTheGreek
previously approved these changes
Oct 15, 2020
|
Rebased again due to another CHANGELOG conflict. |
GregTheGreek
previously approved these changes
Oct 16, 2020
spacesailor24
previously approved these changes
Oct 19, 2020
|
@gabmontes If you can fix the CHANGELOG, we should be able to merge this ASAP |
Since the event handlers are run syncronously, if an `error` event handler thows, the error will return to the lib and keep the promise chain broken, rising an unhandled promise rejection error. Resolves web3#3708
The inner function sendRequest that belongs to Method.buildCall should not return anything. Returning a promise might lead to some dev reading the code to think that any promise rejection would be handled in the caller. But the fact is that all the calls to it (below) just discard anything returned. So better to clean this up.
gabmontes
dismissed stale reviews from spacesailor24 and GregTheGreek
via
bb21562
|
@spacesailor24 solved again. Moved this issue's line in the change log to the top of the fixes so we don't have more conflicts (🤞). |
GregTheGreek
approved these changes
Oct 19, 2020
spacesailor24
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the event handlers are run synchronously, if an
errorevent handler throws in userland, the error will return to the lib and keep thesendRequestpromise chain broken, rising an unhandled promise rejection error. See #3708 for a detailed explanation of the error and how to reproduce.Fixes #3708
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.