Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 3717 #3719

Merged
merged 6 commits into from
Sep 25, 2020
Merged

Fix/issue 3717 #3719

merged 6 commits into from
Sep 25, 2020

Conversation

frankiebee
Copy link
Contributor

@frankiebee frankiebee commented Sep 16, 2020

Description

Fixes #3719

Removes post install scrip in favor of a troubleshooting docs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Sep 16, 2020

Coverage Status

Coverage remained the same at 80.373% when pulling 79f074b on fix/issue-3717 into f19481f on 1.x.

@GregTheGreek
Copy link
Contributor

@frankiebee PR description please :)

README.md Outdated Show resolved Hide resolved
Co-authored-by: Wyatt Barnes <me@wyatt.email>
@GregTheGreek GregTheGreek merged commit 9b92aac into 1.x Sep 25, 2020
@GregTheGreek GregTheGreek deleted the fix/issue-3717 branch September 25, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants