fix eth packages typing issue, not export default #3198

[ariesjia]

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

typing issue, export is not correct.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• [ ] I ran npm run dtslint with success and extended the tests and types if necessary.
• I ran npm run test:unit with success.
• I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
• I ran npm run build and tested dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• [ ] I have updated the CHANGELOG.md file in the root folder.

[coveralls]

Coverage remained the same at 78.042% when pulling e4fa335 on ariesjia:1.x into 9eede51 on ethereum:1.x.

[spacesailor24]

Should this (web3-eth) be a dependency?

[spacesailor24]

So I'm a little confused on why we would want to do something like:

import Contract, { ContractOptions} from 'web3-eth-contract';

If we update the packages, in this case web3-eth-contract, to have the default export be an object containing all the exports such as:

export default {
    Contract,
    ContractOptions
}

You would still be able to do:

import { Contract, ContractOptions} from 'web3-eth-contract';

Am I mistaken, is there a reason you wouldn't want to do it that way?

[ariesjia]

@spacesailor24
The current version the declaration tell us should use import { Contract, ContractOptions } from 'web3-eth-contract'; , but the Contract is got undefined
Because source code is

module.exports = Contract;

for ES module it equals export default. So the typing is not match the source.
If we use import Contract, { ContractOptions } from 'web3-eth-contract';, we will got the correct object , but we will get Typescript compile err due to the declaration.

If we change the export will bring API broken change， this commit is only for quick fix

[BryanLaura]

Fix #3732

[BryanLaura]

export import default

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ariesjia
✅ spacesailor24
❌ frankiebee
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.