-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error message edit #3740
error message edit #3740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Requesting changes because I think the string interpolation is much cleaner, but if you could also update the CHANGELOG with your changes, we can hopefully get this merged in ASAP
thanks @spacesailor24. made another commit with the updated changelog. |
Awesome! Thank you for replying so quickly! If my above change suggestion looks good to you, I think we can commit it and this should be g2g |
Co-authored-by: Wyatt Barnes <me@wyatt.email>
looks good to me, committed! |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.