Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message edit #3740

Merged
merged 4 commits into from
Oct 19, 2020
Merged

error message edit #3740

merged 4 commits into from
Oct 19, 2020

Conversation

djosey
Copy link
Contributor

@djosey djosey commented Oct 9, 2020

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Oct 9, 2020

Coverage Status

Coverage increased (+2.3%) to 80.383% when pulling b3bd22a on djosey:patch-1 into 9eede51 on ethereum:1.x.

Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Requesting changes because I think the string interpolation is much cleaner, but if you could also update the CHANGELOG with your changes, we can hopefully get this merged in ASAP

packages/web3-core-helpers/src/formatters.js Outdated Show resolved Hide resolved
@djosey
Copy link
Contributor Author

djosey commented Oct 19, 2020

thanks @spacesailor24. made another commit with the updated changelog.

@spacesailor24
Copy link
Contributor

Awesome! Thank you for replying so quickly! If my above change suggestion looks good to you, I think we can commit it and this should be g2g

Co-authored-by: Wyatt Barnes <me@wyatt.email>
@djosey
Copy link
Contributor Author

djosey commented Oct 19, 2020

looks good to me, committed!

@GregTheGreek GregTheGreek merged commit 62cb124 into web3:1.x Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants