Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed decoding bytes parameters for logs emitted with solc 0.4.x #3744

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

maqdev
Copy link
Contributor

@maqdev maqdev commented Oct 14, 2020

Description

This fixes event log decoding that contains bytes or string parameters by contracts compiled with solc 0.4.x

Fixes #3724, #3738

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@coveralls
Copy link

coveralls commented Oct 14, 2020

Coverage Status

Coverage decreased (-2.3%) to 78.042% when pulling 7d91f3f on maqdev:1.x into b0f385c on ethereum:1.x.

@spacesailor24 spacesailor24 self-requested a review October 15, 2020 19:12
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the changes and they do seem to fix the errors 🎉

However, this PR commits the built web3js.min.js and web3js.min.js.map files which only happens when a new release is made. So @maqdev, if you could kindly remove those commits from this PR, this should be ready to merge!

@maqdev
Copy link
Contributor Author

maqdev commented Oct 15, 2020

@spacesailor24 web3js.min.js and web3js.min.js.map are removed from the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade abi coder to fix solc 0.4.x edge case
5 participants