Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mkdir directory already exists #3766

Closed
wants to merge 2 commits into from
Closed

Conversation

RakibFiha
Copy link

Description

mkdir directory already exists

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.053% when pulling 8b3caa0 on RakibFiha:patch-1 into edf481d on ethereum:1.x.

@@ -7,7 +7,7 @@
set -o errexit

# Setup mock project to install web3 from virtual registry
mkdir windows_test
mkdir -p windows_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koraykoska was this an issue with you?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@koraykoska koraykoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge the newest 1.x back into this PR and we can approve this.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 553747855

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 226 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.5%) to 76.273%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 8 82.27%
packages/web3-utils/src/utils.js 27 10.74%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.92%
packages/web3-utils/src/index.js 42 32.12%
packages/web3-eth-accounts/src/index.js 85 33.06%
Totals Coverage Status
Change from base Build 538231133: 2.5%
Covered Lines: 3172
Relevant Lines: 3944

💛 - Coveralls

@spacesailor24 spacesailor24 added P3 Low severity bugs Review Needed Maintainer(s) need to review labels Mar 9, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label May 9, 2021
@github-actions github-actions bot closed this May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low severity bugs Review Needed Maintainer(s) need to review Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants