Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Energy Webchain network ENS registry to the known registries #3775

Closed
wants to merge 5 commits into from

Conversation

Agupane
Copy link

@Agupane Agupane commented Nov 4, 2020

Description

This PR does add the Energy Webchain network ENS registry to the ENS config file.

Fixes #3768

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@ngyam
Copy link

ngyam commented Nov 11, 2020

@Agupane can you add volta too? 73799 -> 0xd7CeF70Ba7efc2035256d828d5287e2D285CD1ac

https://energyweb.atlassian.net/wiki/spaces/EWF/pages/555745281/Using+ENS
`

Updates CHANGELOG.md
Updates tests
@coveralls
Copy link

Coverage Status

Coverage increased (+2.4%) to 80.413% when pulling 25dcdf9 on Agupane:issue-3768 into edf481d on ethereum:1.x.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@spacesailor24
Copy link
Contributor

Judging by this comment, we won't be merging these changes in. Hopefully the postinstall patch method works for you guys until web3 verison 1.4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENS Support for EWC
5 participants