Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eth2 packages #3800

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Rename eth2 packages #3800

merged 5 commits into from
Dec 2, 2020

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Dec 1, 2020

Description

Renames the packages:

  • web3-eth2-core to web3-eth2-base
  • web3-eth2-beaconchain to web3-eth2-beacon

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

frankiebee
frankiebee previously approved these changes Dec 1, 2020
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just waiting for tests to pass

@coveralls
Copy link

coveralls commented Dec 1, 2020

Coverage Status

Coverage remained the same at 80.423% when pulling 59ffd01 on wyatt/rename-eth2-packages into 942161c on 1.x.

GregTheGreek
GregTheGreek previously approved these changes Dec 2, 2020
@GregTheGreek
Copy link
Contributor

@spacesailor24 linter issues

@spacesailor24 spacesailor24 merged commit 124b7c0 into 1.x Dec 2, 2020
@spacesailor24 spacesailor24 deleted the wyatt/rename-eth2-packages branch December 2, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants