increase timeouts #3814
Merged
increase timeouts #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacesailor24
approved these changes
Dec 11, 2020
GregTheGreek
previously approved these changes
Dec 11, 2020
GregTheGreek
requested changes
Dec 11, 2020
|
|
||
| const password = "qwerty"; | ||
| const addressFromWallet = wallet[0].address; | ||
| it("encrypt then decrypt wallet", function(done) { |
There was a problem hiding this comment.
the test was changed to be async, you need to make sure that done() is called resolve the test
There was a problem hiding this comment.
done is called on line 413
it possible the timeout is not long enough :{
but hopefully the rerun will fix that.. something in the new update of firefox changed execution time of encrypt
GregTheGreek
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current tests on (rc)[#3757] are failing only in github actions
this fixes that by increasing the timeouts
With the new version of Firefox 83 the time to run the tests have increased thank you @cgewecke for finding this!