Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eth_utils requirement and start using eth_utils.toolz #1056

Closed
dylanjw opened this issue Sep 12, 2018 · 7 comments
Closed

Bump eth_utils requirement and start using eth_utils.toolz #1056

dylanjw opened this issue Sep 12, 2018 · 7 comments

Comments

@dylanjw
Copy link
Contributor

dylanjw commented Sep 12, 2018

  • Version: 4.7.1

replace web3.utils.toolz with eth_utils.toolz

@stefanmendoza
Copy link
Contributor

stefanmendoza commented Oct 10, 2018

@dylanjw So I tried doing this (branch here), but ran into some dependency conflicts related to eth-typing:

ethtoken==0.0.1a3
  - web3 [required: ~=4.0b7, installed: 4.7.1]
    - cytoolz [required: >=0.9.0,<1.0.0, installed: 0.9.0.1]
      - toolz [required: >=0.8.0, installed: 0.9.0]
    - eth-abi [required: >=1.2.0,<2.0.0, installed: 1.2.0]
      - eth-typing [required: <=2, installed: 2.0.0]
      - eth-utils [required: >=1.2.0,<2.0.0, installed: 1.2.2]
        - cytoolz [required: >=0.8.2,<1.0.0, installed: 0.9.0.1]
          - toolz [required: >=0.8.0, installed: 0.9.0]
        - eth-hash [required: >=0.1.0,<1.0.0, installed: 0.2.0]
        - eth-typing [required: >=1.3.0,<2.0.0, installed: 2.0.0]
* py-evm==0.2.0a32
 - eth-typing [required: >=1.1.0,<2.0.0, installed: 2.0.0]
* ethtoken==0.0.1a3
 - web3 [required: ~=4.0b7, installed: 4.7.1]
* eth-utils==1.2.2
 - eth-typing [required: >=1.3.0,<2.0.0, installed: 2.0.0]

I tried messing around with the dependency restrictions, but it comes down to the latest version of eth-abi (including the betas) being flexible enough to use 2.x of eth-typing (see here), so I'm hesitant to make that more restrictive instead of opening it up. Not sure what the best approach would be here. @carver - any thoughts?

Also, for what it's worth, I'm getting this on master when I run pip install -e ".[dev]" with the cache deleted:

eth-utils 1.2.2 has requirement eth-typing<2.0.0,>=1.3.0, but you'll have eth-typing 2.0.0 which is incompatible.
py-evm 0.2.0a32 has requirement eth-typing<2.0.0,>=1.1.0, but you'll have eth-typing 2.0.0 which is incompatible.
ethtoken 0.0.1a3 has requirement web3~=4.0b7, but you'll have web3 4.7.1 which is incompatible.

EDIT: Looks like this was already addressed :)
ethereum/eth-abi#99 / ethereum/eth-abi#100
I think once a patch of eth-abi 1.x is released I can finish up that PR.

@stefanmendoza
Copy link
Contributor

stefanmendoza commented Oct 10, 2018

Logged the issue above. Cross-post from the PR for that issue:

It is interesting that we have a circular dependency on Web3 here. I think the order needs to be:

  1. eth-abi-1.2.1 is released and includes the exclusion of eth-typing >= 2
  2. web3-v4.7.2 will pick this up as it's >=1.2.0
  3. Bump the version here to include non-beta 4.x Web3, which should include the change above. Release.
  4. Web3 will pull in the latest version of ethtoken-0.0.1-alpha.4, which will not have an incompatibility with the Web3 version being installed.

Then we might want to lock the docs version of ethtoken to ethtoken>=0.0.1-alpha.4,<2.0.0 as part of this issue?

@isachard
Copy link

@pipermerriam can I work on this issue?

@pipermerriam
Copy link
Member

Yes, you may!

@AvinashKasukurthi
Copy link

@pipermerriam I am beginner in open source contribution.

I got inspired to work on project web3 that can change the world.
Can you please guide me to work on this issue.

@BoboTiG
Copy link
Contributor

BoboTiG commented Mar 31, 2022

Isn't it already fixed with #1317?

@kclowes
Copy link
Collaborator

kclowes commented Mar 31, 2022

Yep, looks like it. Thanks @BoboTiG!

@kclowes kclowes closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants