Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account to async Eth (backport of #2582) #2590

Merged
merged 1 commit into from Aug 2, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Jul 29, 2022

What was wrong?

backport of #2582

How was it fixed?

  • Move account into BaseEth

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo requested a review from kclowes July 29, 2022 19:32
@fselmo fselmo assigned pacrob and unassigned pacrob Jul 29, 2022
@fselmo fselmo requested review from pacrob and wolovim July 29, 2022 19:33
- Move ``account`` to ``BaseEth`` so it can be accessed by both ``Eth`` and ``AsyncEth``
@fselmo fselmo marked this pull request as ready for review July 29, 2022 19:39
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 8c5dbab into ethereum:v5 Aug 2, 2022
@fselmo fselmo deleted the v5port-async-account branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants