Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove personal namespace support and tests #2844

Closed
Tracked by #2854
fselmo opened this issue Feb 23, 2023 · 0 comments · Fixed by #3350
Closed
Tracked by #2854

Remove personal namespace support and tests #2844

fselmo opened this issue Feb 23, 2023 · 0 comments · Fixed by #3350
Labels
priority: p2 important v7 breaking changes considered for v7

Comments

@fselmo
Copy link
Collaborator

fselmo commented Feb 23, 2023

What was wrong?

  • go-ethereum personal namespace is now deprecated as of v1.11.0. We should sunset the test suite and look into how this will shape the test suite overall.

How can it be fixed?

  • Remove personal namespace and testing.
  • drop rpc.enablepersonal flag from geth args when starting geth for fixtures.
  • Investigate what sort of support may make sense for Clef, if any, and how this will affect the tests moving forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 important v7 breaking changes considered for v7
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated personal namespace fselmo/web3.py
2 participants
@fselmo @kclowes