Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result formatters for reward tracing calls #2929

Merged
merged 1 commit into from Apr 24, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 24, 2023

What was wrong?

  • Related to observation from a comment on a separate issue.

Unfortunately documentation on this type is not great. I found an example in the documented response here for reference.

How was it fixed?

  • Add result formatters for reward trace type action fields. Missing formatter was to_checksum_address for author.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the tracing-reward-author-formatters branch from 16104f2 to b503807 Compare April 24, 2023 16:29
@fselmo fselmo force-pushed the tracing-reward-author-formatters branch from b503807 to 153c2fd Compare April 24, 2023 16:30
@fselmo fselmo marked this pull request as ready for review April 24, 2023 16:31
@fselmo fselmo requested review from kclowes and pacrob April 24, 2023 16:31
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fselmo fselmo merged commit 316b86a into ethereum:master Apr 24, 2023
69 checks passed
@fselmo fselmo deleted the tracing-reward-author-formatters branch April 25, 2023 16:48
Uxio0 added a commit to safe-global/safe-eth-py that referenced this pull request May 8, 2023
Uxio0 added a commit to safe-global/safe-eth-py that referenced this pull request May 8, 2023
Uxio0 added a commit to safe-global/safe-eth-py that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants