Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update matomo script #2978

Merged
merged 1 commit into from Jun 6, 2023
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Jun 5, 2023

What was wrong?

  • matomo moving from on-premises to cloud. tag script needs tweaking accordingly, and is a copy pasta from their settings page.

Todo:

Cute Animal Picture

@fselmo
Copy link
Collaborator

fselmo commented Jun 5, 2023

is a copy pasta from their settings page

Do you have the settings page for reference?

@wolovim
Copy link
Member Author

wolovim commented Jun 5, 2023

Do you have the settings page for reference?

@fselmo not publicly accessible; requires login to the cloud provider and is found on the settings page for the web3py project. devops can provide creds.

@fselmo
Copy link
Collaborator

fselmo commented Jun 5, 2023

looks like the settings page 👍🏼

@@ -1,11 +1,12 @@
var _paq = window._paq || [];
var _paq = window._paq = window._paq || [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any effect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that i can see in this script. maybe just best practice/future proofing.

@wolovim wolovim merged commit c991355 into ethereum:main Jun 6, 2023
69 checks passed
@wolovim wolovim deleted the docs-matomo-cloud branch June 6, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants