Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience around provider-specific middlewares #2990

Closed
Tracked by #2854
fselmo opened this issue Jun 8, 2023 · 0 comments · Fixed by #3169
Closed
Tracked by #2854

Improve user experience around provider-specific middlewares #2990

fselmo opened this issue Jun 8, 2023 · 0 comments · Fixed by #3169

Comments

@fselmo
Copy link
Collaborator

fselmo commented Jun 8, 2023

What was wrong?

  • Currently there is a middleware onion on the RequestManager and there are provider-specific middlewares. This leads to confusion like in Option for turning off HTTPRequestRetry #2770. We should re-think the way that request retry is handled in a more user-friendly way.

How can it be fixed?

One possible solution is to remove the idea of middlewares on providers and leave it to the middleware onion only. If we want to add some provider-specific features, these might be nice features as flags on the provider instead or as provider-specific middleware that may be added to the onion itself in the RequestManager class.

Suggestions / opinions encouraged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant