Minor internal fixes #3069
Merged
Minor internal fixes #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jul 31, 2023
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jul 31, 2023
- Add newsfragment for ethereum#3069
fselmo
force-pushed
the
minor-internal-async-fixes
branch
from
a5341dd
to
6281844
Compare
- Add newsfragment for ethereum#3069
fselmo
force-pushed
the
minor-internal-async-fixes
branch
from
6281844
to
4112229
Compare
reedsa
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Web3class with async providers in the setup. UseAsyncWeb3. I don't believe this should have much of an effect other than the type hinting being corrected.How was it fixed?
Web3(async_provider)->AsyncWeb3(async_provider)Todo:
Cute Animal Picture