Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore flake8 F401 qa in all __init__.py files #3097

Merged
merged 1 commit into from Sep 14, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Sep 14, 2023

What was wrong?

Flake8 rule F401 requires that an import be used, but __init__.py files are specifically for importing various functions to then be imported elsewhere

How was it fixed?

Tell flake8 to ignore F401 qa errors in all __init__.py files.

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the ignore-flake8-f401-in-initpy-files branch from 1ca0517 to f4a4127 Compare September 14, 2023 18:39
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@pacrob pacrob merged commit 1b72768 into ethereum:main Sep 14, 2023
84 checks passed
@pacrob pacrob deleted the ignore-flake8-f401-in-initpy-files branch September 14, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants