Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up core tests #3111

Merged
merged 1 commit into from Oct 27, 2023
Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Sep 28, 2023

What was wrong?

Core tests take ~12 min on average to run. We should try to speed this up.

  • use pytest-xdist
  • split sync / async into separate runs
  • ???

Todo:

Cute Animal Picture

image

@fselmo fselmo force-pushed the speed-up-ci-core-test-suite branch 2 times, most recently from 8bc9b72 to c4da6dd Compare September 28, 2023 21:54
@fselmo fselmo force-pushed the speed-up-ci-core-test-suite branch from c4da6dd to 9106468 Compare October 26, 2023 22:48
@fselmo fselmo force-pushed the speed-up-ci-core-test-suite branch from 9106468 to b4c2935 Compare October 26, 2023 23:09
@fselmo fselmo marked this pull request as ready for review October 26, 2023 23:10
@fselmo fselmo changed the title [WIP] Try to speed up core tests Speed up core tests Oct 26, 2023
@fselmo fselmo requested review from pacrob and reedsa October 26, 2023 23:13
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 07a2d4d into ethereum:main Oct 27, 2023
89 checks passed
@fselmo fselmo deleted the speed-up-ci-core-test-suite branch October 27, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants