add upper pin to hexbytes dep due to incoming breaking update in 0.4.0 #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
hexbytes-upper-pin
branch
from
26aa4a8
to
e20cabc
Compare
reedsa
approved these changes
Oct 16, 2023
fselmo
reviewed
Oct 16, 2023
setup.py
Outdated
| @@ -74,7 +74,7 @@ | |||
| "eth-hash[pycryptodome]>=0.5.1", | |||
| "eth-typing>=3.0.0", | |||
| "eth-utils>=2.1.0", | |||
| "hexbytes>=0.1.0", | |||
| "hexbytes>=0.1.0,<=0.3.1", | |||
There was a problem hiding this comment.
See comment here. I think we should use <0.4.0 as the pin if that is the planned version with the breaking changes.
pacrob
force-pushed
the
hexbytes-upper-pin
branch
from
e20cabc
to
94dc866
Compare
fselmo
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The hexbytes lib will be changing the way
Hexbytes.hex()works - ethereum/hexbytes#14How was it fixed?
Add upper pin to hexbytes dep now, then web3 v7 will use hexbytes 0.4.0 as a lower bound.
Todo:
Cute Animal Picture