Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-compile test contracts with Solidity v0.8.22 #3134

Merged
merged 3 commits into from Oct 25, 2023
Merged

Re-compile test contracts with Solidity v0.8.22 #3134

merged 3 commits into from Oct 25, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Oct 25, 2023 •
edited

What was wrong?

Closes #3133

How was it fixed?

  • run compile_contracts.py with -v 0.8.22 and re-generate integration test fixture to ensure all tests are using the latest bytecode.

Todo:

Cute Animal Picture

1000019917

@fselmo fselmo marked this pull request as ready for review October 25, 2023 17:46
@fselmo fselmo requested review from pacrob and reedsa October 25, 2023 17:46
pacrob
pacrob approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 2db5fee into ethereum:main Oct 25, 2023
84 checks passed
@fselmo fselmo deleted the compile-test-contracts-with-solidity-v0.8.22 branch October 25, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reedsa reedsa reedsa approved these changes

@pacrob pacrob pacrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recompile test contracts with new Solidity version: v0.8.22
3 participants
@fselmo @reedsa @pacrob