Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper pin to deprecated lru-dict #3144

Merged
merged 1 commit into from Nov 7, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 7, 2023

What was wrong?

Our linting CI is failing with a new typing issue.

How was it fixed?

  • lru-dict will be removed in web3.py v7. A new minor version is causing some issues with linting. add an upper pin for <1.3.0.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the upper-pin-on-deprecated-lru-dict branch from a46a8bf to 9e81db9 Compare November 7, 2023 21:55
- ``lru-dict`` will be remvoed in web3.py v7. A new minor version is causing some issues with linting. add an upper pin for ``<1.3.0``.
@fselmo fselmo force-pushed the upper-pin-on-deprecated-lru-dict branch from 9e81db9 to 934a35d Compare November 7, 2023 21:59
@fselmo fselmo marked this pull request as ready for review November 7, 2023 22:01
@fselmo fselmo requested a review from reedsa November 7, 2023 22:02
@fselmo fselmo merged commit ec37f2f into ethereum:main Nov 7, 2023
85 of 89 checks passed
@fselmo fselmo deleted the upper-pin-on-deprecated-lru-dict branch November 7, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants