Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pytest-asyncio #3160

Merged
merged 2 commits into from Dec 4, 2023
Merged

Pin pytest-asyncio #3160

merged 2 commits into from Dec 4, 2023

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Dec 4, 2023 •
edited

What was wrong?

pytest-asyncio v0.23 changed something that caused all of our async tests to fail. Putting this up so we can move on, but I'll circle back soon.

How was it fixed?

Pinned to <0.23

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review December 4, 2023 20:53
pacrob
pacrob approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 2d63c14 into ethereum:main Dec 4, 2023
89 checks passed
@kclowes kclowes deleted the pin-pytest-asyncio branch December 4, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@reedsa reedsa Awaiting requested review from reedsa

@fselmo fselmo Awaiting requested review from fselmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kclowes @pacrob