break up tox test runs with underscores where they should be unique
#3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
name-ethtester-tox-runs-similarly
branch
from
1b2ea67
to
6a2ad06
Compare
fselmo
force-pushed
the
name-ethtester-tox-runs-similarly
branch
from
6a2ad06
to
c212c68
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Dec 15, 2023
- ``tox`` seems to be picking up multiple patterns otherwise, when looking at the ``commands`` in ``testenv``
fselmo
force-pushed
the
name-ethtester-tox-runs-similarly
branch
from
c212c68
to
b724530
Compare
fselmo
changed the title
tox test runs with underscores where they should be unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to PR #3157
How was it fixed?
toxis looking atcommandsin the tox.initestenvsection and running similarly named hyphenated commands together. Breaking up the naming with_underscores where they need to be unique seems to fix this.Todo:
Cute Animal Picture
Big thanks to Eric Lam for the watermarked bug picture I just found