New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contract Events Sorted by ContractEvent.logIndex
and ContractEvent.blockNumber
#3228
Conversation
61de8ba
to
f94b8ec
Compare
f94b8ec
to
0212931
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we need to update any docs?
0212931
to
7a4cef1
Compare
7a4cef1
to
531fb30
Compare
Committed a change to also sort the events by |
ContractEvent.logIndex
and ContractEvent.blockNumber
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
What was wrong?
Closes #961
How was it fixed?
Pass log entries list through
sorted
to return a list sorted by all event'sblockNumber
andlogIndex
esTodo:
Cute Animal Picture