Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Web3Exception for all exceptions within the library #3241

Closed
Tracked by #2854
fselmo opened this issue Feb 22, 2024 · 1 comment · Fixed by #3300
Closed
Tracked by #2854

Use Web3Exception for all exceptions within the library #3241

fselmo opened this issue Feb 22, 2024 · 1 comment · Fixed by #3300

Comments

@fselmo
Copy link
Collaborator

fselmo commented Feb 22, 2024

All exceptions for the library should inherit from Web3Exception for UX improvements on user-side exception handling

closes #1864
@fselmo fselmo mentioned this issue Feb 22, 2024
Closed
@MRLab12
Copy link

MRLab12 commented Mar 23, 2024

@fselmo Hey, I started looking into this and could get a PR up to handle exceptions. I believe we could handle all ValueError and KeyError exceptions in web3/manager.py as suggested in #1864.

@MRLab12 MRLab12 mentioned this issue Mar 25, 2024
Closed
1 task
@fselmo fselmo mentioned this issue Mar 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use in-house Web3 exceptions for all of the codebase fselmo/web3.py
2 participants
@fselmo @MRLab12