New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: middleware refresh #3266
docs: middleware refresh #3266
Conversation
5a658e0
to
5535a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits but looks good. Much better condensed into one page 👍🏼
5535a6c
to
c873446
Compare
c873446
to
eb1eec3
Compare
@fselmo thanks for the feedback. tweaks made, plus moved the API definition up above the list of default middleware. felt like an awkward jump from default middleware -> API definition -> optional middleware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. It's much more cohesive as one page. lgtm 👍🏼
What was wrong?
How was it fixed?
s
;) note the API still has a few cases wheremiddlewares
appears with ans
. a problem for not this PR.Todo:
Cute Animal Picture