Fix process_log for HexStr inputs
#3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Mar 18, 2024
reedsa
force-pushed
the
event-data-coercion-v7
branch
from
2da8c5b
to
b8a0691
Compare
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Mar 18, 2024
reedsa
force-pushed
the
event-data-coercion-v7
branch
from
b8a0691
to
690a03e
Compare
fselmo
approved these changes
Mar 21, 2024
pacrob
approved these changes
Mar 22, 2024
`HexStr` values now converted to bytes for processing
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Mar 25, 2024
reedsa
force-pushed
the
event-data-coercion-v7
branch
from
690a03e
to
722df5c
Compare
reedsa
force-pushed
the
event-data-coercion-v7
branch
from
71e9467
to
e67db77
Compare
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #3286
Realized the topics and data values had not been explicitly converted to bytes. The initial fix I made was to convert the log topics to a
HexStrbut since bytes are needed later on, it made sense to just ensure everything is coerced to bytes before handling them.How was it fixed?
Explicit type coercion of entry
topicsanddatavalues.Todo:
Cute Animal Picture