Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatters for type 3 transaction fields #3314

Merged
merged 2 commits into from Mar 28, 2024
Merged

Add formatters for type 3 transaction fields #3314

merged 2 commits into from Mar 28, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Mar 28, 2024 •
edited

What was wrong?

Add formatters for type 3 transaction fields:

  • maxFeePerBlobGas
  • blobVersionedHashes

Todo:

Cute Animal Picture

Screenshot 2024-03-28 at 12 55 26

@fselmo fselmo mentioned this pull request Mar 28, 2024
Merged
1 task
@fselmo fselmo marked this pull request as ready for review March 28, 2024 18:55
@fselmo fselmo requested review from pacrob and reedsa March 28, 2024 18:56
pacrob
pacrob approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 5fbd9a9 into ethereum:main Mar 28, 2024
81 checks passed
@fselmo fselmo deleted the cancun-field-formatters branch March 28, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@reedsa reedsa Awaiting requested review from reedsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fselmo @pacrob