Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove code that was needed for py<=37 #3317

Merged
merged 1 commit into from Mar 29, 2024
Merged

remove code that was needed for py<=37 #3317

merged 1 commit into from Mar 29, 2024

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Mar 29, 2024 •
edited

What was wrong?

Removing code that was conditionally needed for python<=3.7

Todo:

Cute Animal Picture

image

@pacrob pacrob marked this pull request as ready for review March 29, 2024 20:52
@pacrob pacrob requested review from fselmo and kclowes March 29, 2024 20:52
fselmo
fselmo approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! love that cleanup.. lgtm 👍🏼

@pacrob pacrob merged commit afbb195 into ethereum:main Mar 29, 2024
81 checks passed
@pacrob pacrob deleted the drop-py37-code branch March 29, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@kclowes kclowes Awaiting requested review from kclowes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacrob @fselmo