Retrieve endpoint_uri or ipc_path from base persistent provider class #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Mar 29, 2024
fselmo
force-pushed
the
redefine-persistent-connection-provider-paths
branch
from
0c7596b
to
7596de6
Compare
kclowes
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ipc_pathvariable withendpoint_uri#3264Since we defined
endpoint_uriat thePersistentConnectionProviderlevel, we used it in themanager.pysince it wouldn't raise any attribute errors. Rather than rename theipc_pathinAsyncIPCProvider, I think it makes sense to have this separation of paths but be able to retrieve either path from the base class as well since we may want to implement logic for the base class (as is the case inmanager.py).How was it fixed?
endpoint_uri_or_ipc_pathproperty in the base class to be able to return the proper path depending on the type of persistent connection provider.Todo:
Cute Animal Picture