Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format max fee per blob gas for requests #3322

Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 1, 2024

What was wrong?

We were missing some field formatters for Cancun

How was it fixed?

  • Add request formatter for maxFeePerBlobGas
  • Add result formatters for blobGasPrice and blobGasUsed for eth_getTransactionReceipt.

Todo:

Cute Animal Picture

20240401_090626

fselmo added a commit to fselmo/web3.py that referenced this pull request Apr 1, 2024
@fselmo fselmo marked this pull request as ready for review April 1, 2024 15:05
@fselmo fselmo force-pushed the format-max-fee-per-blob-gas-for-requests branch from ee08621 to 0dd0c9d Compare April 1, 2024 15:10
@fselmo fselmo requested review from kclowes and pacrob April 1, 2024 15:10
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 7109733 into ethereum:main Apr 1, 2024
81 checks passed
@fselmo fselmo deleted the format-max-fee-per-blob-gas-for-requests branch April 1, 2024 17:39
@fselmo fselmo mentioned this pull request Apr 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants