update uses of messageHash and rawTransaction from eth-account to snakecase version per eth-account v0.12.2 #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
camel-snek-messageHash-rawTransaction
branch
from
7dc38fd
to
897318d
Compare
fselmo
approved these changes
Apr 16, 2024
3348.deprecation.rst
Outdated
| @@ -0,0 +1 @@ | |||
| ``eth-account`` ``messageHash`` and ``rawTransaction`` deprecated for snake_case versions | |||
There was a problem hiding this comment.
nit:
Suggested change
| ``eth-account`` ``messageHash`` and ``rawTransaction`` deprecated for snake_case versions | |
| ``eth-account``, ``messageHash``, [optional oxford comma] and ``rawTransaction`` deprecated for snake_case versions |
There was a problem hiding this comment.
Yeah, cleaned that up.
3 tasks
pacrob
force-pushed
the
camel-snek-messageHash-rawTransaction
branch
from
897318d
to
eebe23b
Compare
v6 has its own version getting worked. This is failing now, but I think yes, once |
|
We will need to make the |
3 tasks
…kecase version per eth-account v0.12.2, bump eth-account dep to >=0.12.2
pacrob
force-pushed
the
camel-snek-messageHash-rawTransaction
branch
from
eebe23b
to
0811a87
Compare
kclowes
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth-accountv0.12.2 deprecatedmessageHashformessage_hashandrawTransactionforraw_transaction.How was it fixed?
Changed all examples to use the snakecase version. In one example in
web3.eth.account.rst, bothmessageHashandmessage_hashkeys are present.Todo:
Cute Animal Picture