Snake case the remaining camels #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Apr 17, 2024
- some remaining cases of ``blockHash`` - ``fromBlock`` - ``toBlock`` ... add newsfragment for ethereum#3353
fselmo
force-pushed
the
snake-case-the-remaining-camels
branch
from
cdf5d67
to
b6dec86
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Apr 17, 2024
- some remaining cases of ``blockHash`` - ``fromBlock`` - ``toBlock`` ... add newsfragment for ethereum#3353
fselmo
force-pushed
the
snake-case-the-remaining-camels
branch
from
b6dec86
to
7e6f384
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Apr 17, 2024
- some remaining cases of ``blockHash`` - ``fromBlock`` - ``toBlock`` ... add newsfragment for ethereum#3353
fselmo
force-pushed
the
snake-case-the-remaining-camels
branch
from
7e6f384
to
653b8cd
Compare
- some remaining cases of ``blockHash`` - ``fromBlock`` - ``toBlock`` ... add newsfragment for ethereum#3353
fselmo
force-pushed
the
snake-case-the-remaining-camels
branch
from
653b8cd
to
9f86289
Compare
fselmo
added a commit
that referenced
this pull request
Apr 18, 2024
- some remaining cases of ``blockHash`` - ``fromBlock`` - ``toBlock`` ... add newsfragment for #3353
kclowes
reviewed
Apr 18, 2024
|
|
||
| Note that if a dictionary is used instead, say to a call such as `eth_getLogs`, the | ||
| keys in the dictionary should be camelCase. This is because the dictionary is passed | ||
| directly to the JSON-RPC request, where the keys are expected to be in camelCase. |
There was a problem hiding this comment.
What do you think about adding a formatter for the case of getLogs and friends? Basically it would look at the TxDict and flip any snake_case to camelCase to be passed on to the node. Then on the way back out it would do the same.
There was a problem hiding this comment.
I'd be good with that if the user experience would benefit from it. The way it is now, users are aware the transactions need to have camelCase arguments as well i.e. {"maxFeePerGas": 10**9, ...}. I think this is a similar case to that but I do think it's a touch more confusing because of the way it can be used by passing in kwargs which are snake-cased. I could go either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #3085
How was it fixed?
fromBlock,toBlock, andblockHashTodo:
Cute Animal Picture