Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auction Dapp #419

Merged
merged 3 commits into from Apr 9, 2018
Merged

Add Auction Dapp #419

merged 3 commits into from Apr 9, 2018

Conversation

iNDicat0r
Copy link
Contributor

@iNDicat0r iNDicat0r commented Apr 7, 2018

Auction Dapp covers:

  • Auction House contracts and ERC721 compliant Token/Deed Repository
  • Data storage on swarm
  • Whisper messaging
  • Frontend and web3 interactions with the smart contracts

Demo: http://52.59.238.144/
Available on Ropsten
Or
Add Cuctom RPC in metamask and insert the following address:

http://52.59.238.144:8545/

Add these test accounts:

address: 0xC1DF06368AFB95ABe7154978786213A99887aD2A
privateKey: be97a9660105da2a4e2e631b067ac4e08cabdcb2bc85b061b7ffc51d2219162a

address: 0xfFbeB6b8fc95D34535cb89c0b034595E87BE9a31
privateKey: 31013408a0776fe01f2a3cd9306c1780f4188ed577083ecda5b9d27b480808fd

Contributions and improvements are needed!

@fjrojasgarcia
Copy link
Contributor

At first glance a fascinating job. This revision takes time. Review in progress. Please be patient.

@fjrojasgarcia
Copy link
Contributor

fjrojasgarcia commented Apr 8, 2018

Creating a new Auction, leave me in "Please wait" screen status indefinitely.
I'm still investigating.
screencapture2018-04-08

@iNDicat0r
Copy link
Contributor Author

iNDicat0r commented Apr 8, 2018

Creating a new auction requires an item(deed) to be:

  1. Registered
  2. Transfered to the auction house address
  3. You would need some balance since i deployed to private testnet

@fjrojasgarcia are you on your network or the one i deployed?

@iNDicat0r
Copy link
Contributor Author

Added some test accounts on the private network. Import them using Metamask:

address: 0xC1DF06368AFB95ABe7154978786213A99887aD2A
privateKey: be97a9660105da2a4e2e631b067ac4e08cabdcb2bc85b061b7ffc51d2219162a

address: 0xfFbeB6b8fc95D34535cb89c0b034595E87BE9a31
privateKey: 31013408a0776fe01f2a3cd9306c1780f4188ed577083ecda5b9d27b480808fd

@zasnicoff
Copy link
Contributor

I noticed some nodes connected to Ropsten when I accessed the page, so I figured it was deployed on Ropsten. If not, please ignore my report below and let me know how to connect to your testnet.

Connected to Auction Dapp:

Testnet: ROPSTEN
Address: 0xC1DF06368AFB95ABe7154978786213A99887aD2A
Got a couple of ETH from Faucet
Auto-generated token ID: 822513407211220862
Reference URI: http://zasnicoff.com
Sent Tx through MetaMask
TxHASH: 0x5793358f6a4dc26f496c580640f706109876ee9584cedbeff46f02417cb518a5
Page kept waiting... tried to refresh...
Could not complete 3rd step (create auction)
No tokens/auctions listed on the page

Can I still create an auction?

Let me know how can I help with more tests, thanks.

@iNDicat0r
Copy link
Contributor Author

@zasnicoff The contracts are currently deployed to a private network.(Will be on Ropsten soon).
In the meantime, you could point Metamask to 'Custom RPC' at:

http://52.59.238.144:8545/

and use the keys that i have posted above(import account in metamask using privatekey) to create Token/Deed and auctions.

@zasnicoff
Copy link
Contributor

zasnicoff commented Apr 8, 2018

@iNDicat0r
Test report:

Account
0xc1df06368afb95abe7154978786213a99887ad2a
Starting balance: 20ETH

Create token
ID: 811132136332061519
URI: https://openclipart.org/download/217900/Tshirt-kanji.svg
TxHASH: 0x8a013519469dfb95c6e4ff7e146488b2b0eb617f1c3abd3a8b183354445828f3
nounce 0

Transfer ownership
TxHASH: 0xac49f6a32bda8ce6194e01822d8e1596f12b21a75cd943458b4a2a3aba7fed8c
nounce 1

Both Tx to same contract address:
0xFc35c45C...0dCC
(seems odd that MetaMask has no easy way to show destination address after Tx is done)

Create auction
High CPU usage / delay to create auction
TxHASH: 0xbaf0e25444383eb173cbb2310ff8a192a971321f25dec4bc6ed3f5317b35010e
nounce 2
To address: 0xefBEBbf64a570F7b94f168430f45EcBb87546f06

Auction listed on website.
Won’t show .svg images, though.

BID
DigiDonkey
Deed ID: 206450260337184830
0.15ETH transferred
TxHASH: 0x5aede1b928184afa5b10b24a2ac6b11c42c6ead055b9c5b18af9b9044b6c9f04
nouce 3
To address: 0xefBEBbf64a570F7b94f168430f45EcBb87546f06

Page reflected BID.

I would recommend showing BIDS in the front page for each token.

@iNDicat0r
Copy link
Contributor Author

@zasnicoff Thanks for the report.
In order to show images, upload .png, .jpg or any valid image file. I haven't included any logic for handling vectors and other files, will be added sequentially.

Showing bids in homepage is a good idea, but it costs an extra http call for each auction.

@fjrojasgarcia
Copy link
Contributor

fjrojasgarcia commented Apr 9, 2018

Ok, I'm now working with your private network and addresses ...

sc2018-04-09 02-57-33

... but still stuck in asset deploying phase.

sc-2018-04-09

As url Ii'm using https://pbs.twimg.com/profile_images/683736320691298305/jHM6N6FK_400x400.png

@fjrojasgarcia
Copy link
Contributor

Also tested with an IPFS url lke https://ipfs.infura.io/ipns/QmQwXxKgZ3C6a225eKYov1JxPEexZ1cUo3DfPKHtBUdbCj/dapper/truffle-react/

I'm also stuck in the deploying step ...
screen-capture-2018-04-09

@fjrojasgarcia
Copy link
Contributor

fjrojasgarcia commented Apr 9, 2018

I have seen your comments in Gitter stating that now we can use Ropsten.

  • Registering asset:
    asset was successfully created

I've just registered a tiny React based DApp as a Token!

@fjrojasgarcia
Copy link
Contributor

fjrojasgarcia commented Apr 9, 2018

IMO I would aprove this PR.
Awesome work @iNDicat0r!

@fjrojasgarcia
Copy link
Contributor

@iNDicat0r would you please remove the temporary file code/auction_dapp/..gitignore.swp from the PR?

@iNDicat0r
Copy link
Contributor Author

@fjrojasgarcia Thanks, let me know about improvments and new proposals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants