Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules to Prevent Approvers from Ninja-Tweeting #17

Closed
ghost opened this issue Oct 12, 2022 · 2 comments
Closed

Rules to Prevent Approvers from Ninja-Tweeting #17

ghost opened this issue Oct 12, 2022 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 12, 2022

When a proposal gets a review all other reviewers can review and edit the Tweet afterwards and broadcast anything they want?
If the file gets edited I would like to see a reset and the need for a new review quota.

@IstoraMandiri
Copy link
Collaborator

Good point, we'll need to figure out how to do this in github.

I think we need to be doing it be highlighting specific lines in the tweet when making review approvals.

@IstoraMandiri IstoraMandiri changed the title Hijack Rules to Prevent Approvers from Ninja-Tweeting Oct 13, 2022
@IstoraMandiri
Copy link
Collaborator

I have fixed this

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant