Code size error when actual failure reason is OOG

[davidmurdoch]

ethereumjs-monorepo/packages/evm/src/evm.ts

Line 584 in 49c2d93

result = { ...result, ...CodesizeExceedsMaximumError(message.gasLimit) }

[jochem-brouwer]

I assume you want us to branch on:

1. If returned code size > max code size, report current error
2. Else, return OOG error

?

[davidmurdoch]

I didn't mean to open this yet. I was using the github.dev editor and it opened it for me, I thought I'd have a chance to add more context first.

Context coming right up!

[davidmurdoch]

This issue came up recently when web3 was updating their tests to shanghai. The error returned by the EVM is that the code size is too great, but the gas used was the problem and their contract deployment actually doesn't have enough gas under shanghai.

I suspect they'll be many more users upgrading to shanghai that run into this erroneous error message over the next few months. So it'd be helpful to update the error messaging here soon.

(sorry for that initial contextless issue!)

[jochem-brouwer]

This is not related to Shanghai. This does the "deployed code size" check, not the "initcode size check" (EIP 3860). See EIP https://eips.ethereum.org/EIPS/eip-170

I agree we should change though.

[davidmurdoch]

I think it is related to shanghai. Code that use to deploy successfully at a given gas limit no longer does because init code uses more gas now.

[jeffsmale90]

I this this is a duplicate of this issue #2466 ?

[davidmurdoch]

It is. Thanks @jeffsmale90! I leave it to @jochem-brouwer to close this one.

[jochem-brouwer]

Yup, just assigned #2466 to me and will work on this soon.