Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSTORE Test Coverage #502

Closed
holgerd77 opened this issue Apr 30, 2019 · 1 comment
Closed

SSTORE Test Coverage #502

holgerd77 opened this issue Apr 30, 2019 · 1 comment
Labels
effort: E1 hours help wanted package: vm prio: P3 important type: tests

Comments

@holgerd77
Copy link
Member

Taken from #449.

Since we are not running Constantinople (the old one) fork rules for coverage the whole new SSTORE test is now left completely untested, we actually do might want to reintegrate some of just removed constantinopleSstoreTest test cases (see #437) to get some basic coverage, but maybe just as some single test cases in the new runCode API tests in some adopted format. Eventually these tests need also some modified setup to be a bit more flexible on adding new test cases, nevertheless a superb start that we have that at all.
@holgerd77 holgerd77 mentioned this issue Apr 30, 2019
Closed
@holgerd77 holgerd77 mentioned this issue Aug 21, 2019
Closed
18 tasks
@holgerd77
Copy link
Member Author

This is now covered by the nightly test:state:allForks run, will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: E1 hours help wanted package: vm prio: P3 important type: tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evertonfraga @holgerd77