fromRpcSig and toRpcSig should have an option to include the geth header

[axic]

"\x19Ethereum Signed Message:\n" + len(message).

For more see ethereum/go-ethereum#2940.

(From #60.)

[Neurone]

I think this issue can be closed: since the merge of #67 it seems to me there's no more reason to modify fromRpcSig and toRpcSig.

[holgerd77]

@Neurone Thanks for taking on on this. Actually I am not getting this issue in the first place, this added Geth header doesn't touch the r,s,v values, or does it?

[Neurone]

@holgerd77 No, it does not. The Geth header is added to the payload before signing it: hashPersonalMessage already does exactly that.