Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stateManager, storageReader and cache to state module #443

Merged
merged 2 commits into from Feb 21, 2019
Merged

Move stateManager, storageReader and cache to state module #443

merged 2 commits into from Feb 21, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Feb 21, 2019

No description provided.

@coveralls
Copy link

coveralls commented Feb 21, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 89.396% when pulling 8bf3c1b on refactor/state-module into d0ad8d1 on master.

@s1na
Copy link
Contributor Author

s1na commented Feb 21, 2019

Hm, I'm not sure why coverage is not evaluating storageReader correctly. Tried a couple of things, still no luck.

@holgerd77
Copy link
Member

I can't review as quick as you code. 😃😃😃

@s1na
Copy link
Contributor Author

s1na commented Feb 21, 2019

😅 😅

I think I found the culprit

holgerd77
holgerd77 approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@holgerd77 holgerd77 merged commit c842d10 into master Feb 21, 2019
@holgerd77 holgerd77 deleted the refactor/state-module branch February 21, 2019 16:22
@holgerd77 holgerd77 mentioned this pull request Feb 28, 2019
Closed
11 tasks
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s1na @coveralls @holgerd77 @evertonfraga