Migrate stateManager and storageReader to es6 class syntax #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
previously approved these changes
Feb 25, 2019
| this._cache = new Cache(this._trie) | ||
| this._touched = new Set() | ||
| this._touchedStack = [] | ||
| this._checkpointCount = 0 |
| @@ -11,557 +11,524 @@ const rlp = utils.rlp | |||
|
|
|||
| /** | |||
| * Interface for getting and setting data from an underlying | |||
| * state trie | |||
| * @interface StateManager | |||
There was a problem hiding this comment.
Not have a strong opinion about this, just for clarification: did this not fit enough the definition of the tag?
| */ | ||
| copy () { | ||
| return new StateManager({ trie: this._trie.copy() }) | ||
| } |
| */ | ||
| getAccount (address, cb) { | ||
| this._cache.getOrLoad(address, cb) | ||
| } |
| this._touched.add(address.toString('hex')) | ||
| // self._trie.put(addressHex, account.serialize(), cb) | ||
| cb() | ||
| } |
| cb(err) | ||
| } | ||
| }) | ||
| } |
| address = utils.toBuffer(address) | ||
| this._trie.put(address, account.serialize(), done) | ||
| }, cb) | ||
| } |
| self._touched.clear() | ||
| cb() | ||
| }) | ||
| } |
| this._touched.clear() | ||
| cb() | ||
| }) | ||
| } |
| }) | ||
| }) | ||
| } |
holgerd77
force-pushed
the
refactor/es6-state
branch
from
ed02246
to
c9c7781
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.