Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utils.toBuffer instead of BN.toBuffer #458

Merged
merged 2 commits into from Mar 11, 2019
Merged

Use utils.toBuffer instead of BN.toBuffer #458

merged 2 commits into from Mar 11, 2019

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Mar 1, 2019 •
edited

fix #457

s1na
s1na reviewed Mar 3, 2019
View reviewed changes
lib/vm/opFns.js Outdated Show resolved Hide resolved
@holgerd77
Copy link
Member

Can you squash the two commits and use a meaningful commit message?

holgerd77
holgerd77 approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@holgerd77 holgerd77 merged commit 9b1b24a into ethereumjs:master Mar 11, 2019
@Woodpile37 Woodpile37 mentioned this pull request Aug 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1na s1na s1na left review comments

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BN.toBuffer in the browser
4 participants
@yann300 @holgerd77 @s1na @evertonfraga