Add Karma browser testing for the API tests #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
force-pushed
the
add-api-browser-testing
branch
from
7f71a06
to
8843bda
Compare
|
Had to fix some linting errors and do some CI config modification, but this is now running through and should be ready for review. |
s1na
reviewed
Mar 5, 2019
holgerd77
force-pushed
the
add-api-browser-testing
branch
from
8843bda
to
67d5d0b
Compare
|
Rebased this. |
|
Hi @s1na, since this is not touching any production code and improvements can easily be done on top, I would admin-merge this now, then Jacky can do subsequent test work on top and directly consider this along with his new tests. I will also set the browser tests to being "required" for CI to pass from now on. |
|
Makes sense. Sorry for not testing in time... |
|
No problem. 😄 |
This was referenced Mar 6, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds browser API testing to the VM.
It uses a Karma setup similar to the one in the tx library, adds a new npm script command
testAPI:browserand integrates into CI.This should help prevent issues like #457. I tested this specific case by injecting the error in a matching test and this would actually break the test run.
There were many files not running through and after some experimenting I decided not to try to fix since this seemed to be too much which would have to be addressed. Instead this PR provides the ground for further fixes by providing an initial list of running + excluded test files in the Karma configuration (
karma.conf.js). File runs can then fixed case-by-case by opening separate PRs.One exception to the non-fix approach is that I replaced
promisifyin the test files with a fitting polyfill/shim where it fixed the tests.