Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More system operations test #113

Merged
merged 5 commits into from
May 12, 2017
Merged

More system operations test #113

merged 5 commits into from
May 12, 2017

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented May 12, 2017

See commits for details. Those that are commented out in jsontests/tests/system.rs are the last tests that are needed to pass for a functional EVM.

@sorpaas
Problem: system operation tests was not added
054626c 
Solution: add it and comment out non-passing tests
@sorpaas
Problem: aBacalls0 test fails
fcdcae2 
Solution: fix it
@sorpaas
Problem: zero topup and withdraw fails
275b7ed 
Solution: remove the assert!
@sorpaas
Problem: some tests are commented out
10d4d74 
Solution: add those tests that pass
@coveralls
Copy link

coveralls commented May 12, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 86.146% when pulling 10d4d74 on sorpaas:master into c95e756 on ethereumproject:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 86.146% when pulling 10d4d74 on sorpaas:master into c95e756 on ethereumproject:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 86.146% when pulling 10d4d74 on sorpaas:master into c95e756 on ethereumproject:master.

@sorpaas
Problem: submachine gas was not added
8f54763 
Solution: add then when applying submachine
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 85.884% when pulling 8f54763 on sorpaas:master into c95e756 on ethereumproject:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 85.884% when pulling 8f54763 on sorpaas:master into c95e756 on ethereumproject:master.

@coveralls
Copy link

coveralls commented May 12, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 85.884% when pulling 8f54763 on sorpaas:master into c95e756 on ethereumproject:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 85.884% when pulling 8f54763 on sorpaas:master into c95e756 on ethereumproject:master.

@sjmackenzie sjmackenzie merged commit 5f6a5eb into ETCDEVTeam:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sorpaas @coveralls @sjmackenzie